SteUP_Dotnet/.impeccable/critique/2026-07-08T13-44-46Z__steup-shared-components-pages-ispezionepage-razor.md

target, total_score, p0_count, p1_count, timestamp, slug

target	total_score	p0_count	p1_count	timestamp	slug
IspezionePage	34	0	1	2026-07-08T13-44-46Z	steup-shared-components-pages-ispezionepage-razor

Critique: IspezionePage (re-run post-fix)

Method: dual-agent (A: design-review · B: detector+evidence). Browser visualization SKIPPED (MAUI Blazor Hybrid / WASM requires app build + auth + runtime state).

Design Health Score

#	Heuristic	Score	Key Issue
1	Visibility of System Status	4	Per-scheda sync badge + reparto "da inviare" counter + granular completion progress + success checkmark
2	Match System / Real World	3	Italian & readable, but status shown ALL-CAPS and scheda title is a raw ActivityTypeId code
3	User Control and Freedom	3	Confirmations everywhere; no abort during long upload (sends irreversible by nature)
4	Consistency and Standards	3	coral=send now consistent; undermined by off-palette amber status chip
5	Error Prevention	4	Export confirms + double-tap guards; completion confirmed + _isBusy guard
6	Recognition Rather Than Recall	4	Grouped by reparto, counters, icons, labels
7	Flexibility and Efficiency	3	Three send paths (scheda/reparto/concludi) powerful but diffuse
8	Aesthetic and Minimalist	3	Clean; one expanded panel still stacks several action types
9	Error Recovery	4	OnError copy reassuring, tech detail to logs
10	Help and Documentation	3	Good empty-state; no hint why send buttons vanish offline
Total		34/40	Strong / ship-worthy with targeted fixes

Anti-Patterns Verdict

LLM assessment: Largely free of AI slop; reads as a genuine field tool. Single-Accent Rule now respected on the action surface — coral is consistently "the send action" (per-scheda Invia, panel Esporta reparto, "da inviare" counter), neutral gray for non-send actions, red reserved for delete. SchedaSyncHelper encodes coral=azione-richiesta / green=fatto. No gradients/glass/side-stripes/identical-grid. One genuine rainbow leak remains: StatusEnumHelper.GetColor() paints the InspectionCard status chip Color.Warning (amber) for InCorso/Verifica — amber is not in the SteUP palette and competes with coral. Status labels are ALL-CAPS (violates Regola del Peso, non del Maiuscolo).

Deterministic scan: detect.mjs clean (exit 0) on IspezionePage.razor, SchedaCard.razor, SpinnerOverlay.razor. CSS scan: 3 advisory design-system-radius findings, all in SpinnerOverlay.razor.css (border-radius 100px/2px) — all confirmed false positives (icon geometry of the animated success-checkmark: arc masks + rounded line caps), not surface radii.

Visual overlays: none — browser visualization not applicable to this target.

Overall Impression

Big jump from the first pass (18→34). The screen now delivers its core promise: sync state is unambiguous per-scheda and per-reparto, the completion moment is reassuring (real progress + success checkmark), destructive/irreversible sends are confirmed and double-tap-guarded, and the single coral accent finally means "send." The remaining issues are a real data-integrity bug in the completion loop and a few palette/copy nits — no longer structural.

What's Working

1. SchedaSyncHelper sync-state system — per-scheda coral "Da inviare" / green "Inviato" badges (icon+text, not color-only) + reparto CountDaInviare() counter. The Offline-è-la-verità principle made concrete.
2. Completion progress + confirmation choreography — SetProgress messages, success checkmark with 1.8s dwell, irreversibility confirm guarded by _isBusy.
3. Guarded, reassuring exports — ExportReparto confirms, guards double-tap, keeps work local on failure with human copy, logs the stack trace.

Priority Issues (remaining)

[P1] Silent scheda skip on completion still shows success

• What: In HandleCompleteInspection, if (apiResponse == null) continue; skips a scheda that failed to save, yet the loop still calls CompleteInspection, sets Completata, and shows "Ispezione inviata".
• Why: The inspection becomes non-editable while one or more schede never reached the server — exactly the data loss PRODUCT.md exists to prevent.
• Fix: track failed schede; if any failed, do NOT complete — surface "N schede non inviate, riprova" and keep them "Da inviare". Complete only when all succeed.
• Command: /impeccable harden

[P2] Off-palette amber status chip

• What: StatusEnumHelper.GetColor() returns Color.Warning (amber) for InCorso/Verifica (InspectionCard status chip).
• Why: Amber isn't in the DESIGN.md palette; a second attention color dilutes coral (Regola dell'Unico Accento).
• Fix: map InCorso/Verifica to Color.Default (neutral) or navy Secondary; keep green Completata, red Annullata.
• Command: /impeccable colorize

[P3] ALL-CAPS status labels

• What: ConvertToHumanReadable returns "IN CORSO", "COMPLETATA".
• Why: Violates Regola del Peso, non del Maiuscolo.
• Fix: sentence case ("In corso", "Completata"); rely on the chip's 700 weight.

[P3] Scheda title is a raw code

• What: <b>@Scheda.ActivityTypeId</b> as the card headline.
• Why: forces decoding an internal identifier in the field.
• Fix: show a human descrizione, fall back to the code only if none.

Minor Observations

• OnSchedaModified uses if (index > 0) — skips index 0, so modifying the FIRST scheda in SchedeList won't replace it in-list (likely a >= 0 bug). Pre-existing; now also on the post-export refresh path.
• Sync model collapsed to two states (DaInviare/Inviato) vs the three-state brief (Locale/Da inviare/Inviato) — acceptable, but "local draft" vs "ready to send" no longer distinguished.
• InspectionCard still has an artificial await Task.Delay(250) skeleton delay — fights "feedback immediato".
• InspectionCard address (info-subtitle, gray-darker, weight 600) is still gray, not ink — mild sun-legibility compromise (verify AA); verify amber-on-white too.
• Offline, all send buttons disappear with no "torna online per inviare" hint — badges show "da inviare" but no next step.

Persona Red Flags (delta)

• Casey (mobile): RESOLVED — FABs Size.Medium (≥44px), flex-wrap. Remaining: per-reparto actions sit in panel TitleContent (top of expanded panel), drifting from the thumb zone on long lists.
• Sam (accessibility): RESOLVED — aria-labels on FABs; sync state icon+text not color-only. Remaining: ALL-CAPS status; verify amber-on-white and gray-darker address hit AA.
• Marco (gloved/offline/sun): RESOLVED — sync visibility + reparto counter answer "what hasn't gone yet." Remaining: offline the send buttons vanish with no explanation; address text still gray not ink.

Questions to Consider

• If completion continues past a failed scheda and still locks the inspection, how does Marco discover which scheda didn't make it once editing is disabled?
• Should the total "da inviare" roll up onto the InspectionCard header, visible before expanding any reparto?
• Three send paths (per-scheda, per-reparto, global concludi) — does that dilute the single primary task? Could per-reparto export be the one canonical action?